Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a Peek / Pop API for the datagram queue #3582

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

marten-seemann
Copy link
Member

Fixes #3550.

This makes it easier to reason about the concurrency properties of the datagram queue. I've been unable to understand how the bug described in #3550 actually arises, but this seems change seems to fix it.

It will also allow us to pack multiple DATAGRAMs into the same QUIC packet, if we desire to do so.

@marten-seemann marten-seemann added this to the v0.30.0 milestone Oct 9, 2022
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 85.50% // Head: 85.49% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (3399ebc) compared to base (424a663).
Patch coverage: 86.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3582      +/-   ##
==========================================
- Coverage   85.50%   85.49%   -0.01%     
==========================================
  Files         139      139              
  Lines       10244    10237       -7     
==========================================
- Hits         8759     8752       -7     
  Misses       1103     1103              
  Partials      382      382              
Impacted Files Coverage Δ
datagram_queue.go 85.37% <84.62%> (-6.12%) ⬇️
packet_packer.go 88.18% <87.50%> (+0.41%) ⬆️
connection.go 76.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marten-seemann marten-seemann merged commit 1f6a9ec into master Oct 11, 2022
@marten-seemann marten-seemann deleted the datagram-queue-peek-pop branch October 11, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

racy datagram queue may lead to deadlock
2 participants